feat: add UUID to user model #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
novakzaballa
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
github-actions
bot
added
feature
matthewelwell
force-pushed
the
feat/add-uuid-to-user-model
branch
from
49d3c52 to
435dee3
Compare
github-actions
bot
added
feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4488 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 1176 1178 +2
Lines 39345 39378 +33
=======================================
+ Hits 38131 38164 +33
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
novakzaballa
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add uuid to user model. This will allow the FE to identify users via their UUID. In order to minimise the overhead in adding identity overrides in the future, however, I have added the uuid to both the sales dashboard and the django admin.
How did you test this code?
Updated a unit test and ran the API locally to confirm the changes to the sales dashboard and the django admin.