fix: add reverse sql to versioning migration #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
matthewelwell
commented
Aug 13, 2024
| test_settings.SKIP_MIGRATION_TESTS is True, | ||
| reason="Skip migration tests to speed up tests where necessary", | ||
| ) | ||
| def test_create_whitelisted_segments_migration( |
There was a problem hiding this comment.
Hmm... this test was not modified. The diff is showing that a file was deleted / created vs the renaming action that actually happened. This test function does not need to be reviewed.
khvn26
reviewed
Aug 13, 2024
khvn26
approved these changes
Aug 13, 2024
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4491 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 1176 1176
Lines 39349 39403 +54
=======================================
+ Hits 38135 38189 +54
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes a previously added migration to include a reverse script to ensure that duplicate segments are not shown after a rollback due to the versioning system added past this point.
How did you test this code?
Added 2 new migration tests and tested the sql script manually on my local database.