Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve Github integration #4498

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat: Improve Github integration #4498

merged 5 commits into from
Sep 4, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 14, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

The current GitHub integration needed neatening up, there was also unnecessary code.

Before

image

After

image

In addition, this will also:

  • Preselect a repository
  • Preselect "Issue"
  • Adding an item doesn't require clicking a save button

How did you test this code?

Currently it looks like adding an integration throws a 500, but I was able to validate that it sends the same payload.

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 14, 2024 17:32
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team August 14, 2024 17:32
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:27pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 3:27pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4498 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4498 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4498 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4498 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4498 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4498 Finished ✅ Results ✅

@kyle-ssg kyle-ssg changed the title feat:Improve Github integration feat: Improve Github integration Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

Uffizzi Preview deployment-55267 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 14, 2024
novakzaballa
novakzaballa reviewed Aug 15, 2024
View reviewed changes
frontend/web/components/GitHubResourcesSelect.tsx
<label className='cols-sm-2 control-label'>
Link new Issue / Pull Request
</label>
<Select
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue that is already linked is still appearing in the list, which will cause an error with the backend when trying to select it again.

Screenshot 2024-08-15 at 10 01 56 AM Screenshot 2024-08-15 at 10 02 03 AM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't spot this in the original provider. Sorted

novakzaballa
novakzaballa reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code looks good, but I left some comments that could cause errors.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 19, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 28, 2024
@kyle-ssg kyle-ssg requested a review from novakzaballa August 28, 2024 15:35
@kyle-ssg kyle-ssg linked an issue Aug 28, 2024 that may be closed by this pull request
GitHub integration - styling issues #4349
Closed
@kyle-ssg kyle-ssg added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 65600a7 Sep 4, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the feat/improve-github-ux branch September 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub integration - styling issues
2 participants
@kyle-ssg @novakzaballa