-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add logic to handle grace period breached for paid accounts #4512
Merged
matthewelwell
merged 4 commits into
main
from
fix/grace-period-breach-for-paid-accounts
Aug 19, 2024
Merged
fix: Add logic to handle grace period breached for paid accounts #4512
matthewelwell
merged 4 commits into
main
from
fix/grace-period-breach-for-paid-accounts
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 1178 1178
Lines 39489 39512 +23
=======================================
+ Hits 38275 38298 +23
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
zachaysan
changed the title
fix: WIP - Add logic to handle grace period breached for paid accounts
fix: Add logic to handle grace period breached for paid accounts
Aug 19, 2024
Docker builds report
|
matthewelwell
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #4513
Handle grace periods for paid accounts will now include the grace period check to see if they've done so in a previous month.
How did you test this code?
Added a check on one existing test and created a new test to handle when grace period has been breached.