Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add logic to handle grace period breached for paid accounts #4512

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Aug 19, 2024

Changes

Fixes #4513

Handle grace periods for paid accounts will now include the grace period check to see if they've done so in a previous month.

How did you test this code?

Added a check on one existing test and created a new test to handle when grace period has been breached.

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 2:16pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 2:16pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 2:16pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Uffizzi Preview deployment-55351 was deleted.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (7034fa4) to head (9d83904).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4512   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files        1178     1178           
  Lines       39489    39512   +23     
=======================================
+ Hits        38275    38298   +23     
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the fix label Aug 19, 2024
@zachaysan zachaysan changed the title fix: WIP - Add logic to handle grace period breached for paid accounts fix: Add logic to handle grace period breached for paid accounts Aug 19, 2024
@github-actions github-actions bot added the fix label Aug 19, 2024
@zachaysan zachaysan marked this pull request as ready for review August 19, 2024 14:18
@zachaysan zachaysan requested a review from a team as a code owner August 19, 2024 14:18
@zachaysan zachaysan requested review from matthewelwell and removed request for a team August 19, 2024 14:18
@github-actions github-actions bot added fix and removed fix labels Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4512 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4512 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4512 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4512 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4512 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4512 Finished ✅ Results

@matthewelwell matthewelwell added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit ba8ae60 Aug 19, 2024
55 checks passed
@matthewelwell matthewelwell deleted the fix/grace-period-breach-for-paid-accounts branch August 19, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
2 participants