Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update email wording for paid customers with API usage notifications #4517

Conversation

zachaysan
Copy link
Contributor

Changes

Update the API usage notification emails to remove mentions of grace period for paid accounts and to point people towards the ToS.

How did you test this code?

Ran the existing tests which all passed.

@zachaysan zachaysan requested a review from a team as a code owner August 19, 2024 15:38
@zachaysan zachaysan requested review from gagantrivedi and removed request for a team August 19, 2024 15:38
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 19, 2024 3:38pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 19, 2024 3:38pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 19, 2024 3:38pm

@github-actions github-actions bot added the api Issue related to the REST API label Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4517 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4517 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4517 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4517 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4517 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4517 Finished ✅ Results

@github-actions github-actions bot added the fix label Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Uffizzi Preview deployment-55359 was deleted.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (7034fa4) to head (0607240).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4517   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files        1178     1178           
  Lines       39489    39489           
=======================================
  Hits        38275    38275           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 5cfdaba Aug 20, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/update_email_wording_for_paid_customers_with_api_usage_notifications branch August 20, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants