fix: audit logs generation for feature state value #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catch ObjectDoesNotExists if the feature state is deleted - Don't pass null to diff_history if the prev history record does not exists
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4525 +/- ##
=======================================
Coverage 96.92% 96.93%
=======================================
Files 1178 1178
Lines 39600 39616 +16
=======================================
+ Hits 38384 38400 +16
Misses 1216 1216 ☔ View full report in Codecov by Sentry. |
Comment on lines
2354
to
2355
|
|
||
| assert response.status_code == status.HTTP_200_OK |
There was a problem hiding this comment.
Suggested change
| assert response.status_code == status.HTTP_200_OK | |
| # Then | |
| assert response.status_code == status.HTTP_200_OK |
| @@ -692,6 +697,24 @@ def test_feature_state_value_get_skip_create_audit_log_if_environment_feature_ve | |||
| assert feature_state.feature_state_value.get_skip_create_audit_log() is True | |||
|
|
|||
|
|
|||
| def test_feature_state_value_get_skip_create_audit_log_for_deleted_feature_state( | |||
There was a problem hiding this comment.
Based on the codecov report, it looks like this isn't actually testing the codepath that you expect.
gagantrivedi
force-pushed
the
fix/fsv-audit-logs-without-history
branch
from
939b594 to
8d4a1b8
Compare
matthewelwell
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
How did you test this code?
Updates test cases