Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect statistics in organisation admin list #4546

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes incorrect statistics in organisation admin list view.

How did you test this code?

Manually:

  1. Run the API locally
  2. Create a project in a given organisation
  3. Confirm that the number of projects in the django admin list is correct
  4. Delete the project
  5. Confirm that the number of projects in the django admin list is correct

@matthewelwell matthewelwell requested a review from a team as a code owner August 28, 2024 10:13
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team August 28, 2024 10:13
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 10:16am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 10:16am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 10:16am

@github-actions github-actions bot added the api Issue related to the REST API label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4546 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4546 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4546 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4546 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4546 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4546 Finished ✅ Results

@github-actions github-actions bot added fix and removed fix labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Uffizzi Preview deployment-55640 was deleted.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (aa234e4) to head (3c1406c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4546   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files        1152     1152           
  Lines       39680    39678    -2     
=======================================
- Hits        38495    38494    -1     
+ Misses       1185     1184    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit bc3ddaf Aug 29, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/organisation-admin-statistics branch August 29, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants