Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grafana): update migration to noop on table name #4571

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes db schema mismatch error caused by #4400 by ensuring the table is not renamed.

How did you test this code?

  1. Checked out main branch
  2. Rolled original migration back (python manage.py migrate grafana 0001)
  3. Checked out this branch
  4. Rolled migration forwards again and verified that database schema looks correct

@matthewelwell matthewelwell requested a review from a team as a code owner September 3, 2024 09:47
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team September 3, 2024 09:47
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 3, 2024 9:47am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Sep 3, 2024 9:47am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Sep 3, 2024 9:47am

@github-actions github-actions bot added api Issue related to the REST API fix labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4571 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4571 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4571 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4571 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4571 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4571 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Uffizzi Preview deployment-55825 was deleted.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.14%. Comparing base (8e371a8) to head (ace36af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4571   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files        1154     1154           
  Lines       39816    39818    +2     
=======================================
+ Hits        38679    38681    +2     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 65b63cf Sep 3, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/update-migration branch September 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants