Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(environment): Add toggle for identity override in local eval #4576

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

gagantrivedi
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

@gagantrivedi gagantrivedi requested a review from a team as a code owner September 4, 2024 05:53
@gagantrivedi gagantrivedi requested review from matthewelwell and removed request for a team September 4, 2024 05:53
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:00am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:00am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:00am

Copy link

sentry-io bot commented Sep 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/util/mappers/engine.py

Function Unhandled Issue
map_environment_to_engine ValidationError: 1 validation error for FeatureStateModel util.mappers.engine in map_feature_state_...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the api Issue related to the REST API label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4576 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4576 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4576 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4576 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4576 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4576 Finished ✅ Results

@github-actions github-actions bot added the feature New feature or request label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Uffizzi Preview deployment-55861 was deleted.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.14%. Comparing base (8e371a8) to head (bb764e7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4576   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files        1154     1155    +1     
  Lines       39816    39838   +22     
=======================================
+ Hits        38679    38701   +22     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change request.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 4, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 4, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 5e82c97 Sep 4, 2024
35 checks passed
@matthewelwell matthewelwell deleted the feat/identity-override-toggle branch September 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants