-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle null cancellation dates #4589
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/organisations/chargebee/webhook_handlers.py
Did you find this useful? React with a 👍 or 👎 |
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
========================================
Coverage 97.15% 97.16%
========================================
Files 1156 1157 +1
Lines 39934 40039 +105
========================================
+ Hits 38797 38902 +105
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
@zachaysan I'm not sure why testing is N/A here? Let's make sure that we add some test coverage please. |
This is done now @matthewelwell |
Changes
Trials mean we don't always get cancellation dates in the response from Chargebee. This fixes this.
How did you test this code?
Edit: There is now testing in place. The one path where
current_term_end
is set was covered by an existing test, so I've added one new one for the case where it is unset.