Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multivariate toggle #4594

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: multivariate toggle #4594

merged 1 commit into from
Sep 6, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Currently, clicking the switch to toggle a multivariate feature flag does not work due to not having feature state variation options. Rather than add another code path for such a slim usecase, attempting to switch on an MV flag directly will just open the feature flag modal (same as change requests).

How did you test this code?

  • Attempt to switch on an MV flag

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 6, 2024 08:22
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 8:23am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 8:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 6, 2024 8:23am

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4594 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4594 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4594 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4594 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4594 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4594 Finished ✅ Results

@github-actions github-actions bot added the fix label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Uffizzi Preview deployment-55944 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 4e85975 Sep 6, 2024
31 checks passed
@matthewelwell matthewelwell deleted the fix/multivariate-toggle branch September 6, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants