Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add use_identity_overrides_in_local_eval setting #4612

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 10, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

image

How did you test this code?

Toggled setting

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 10, 2024 13:44
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 1:49pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 1:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 10, 2024 1:49pm

@kyle-ssg kyle-ssg linked an issue Sep 10, 2024 that may be closed by this pull request
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4612 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4612 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-4612 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4612 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4612 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4612 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4612 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4612 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4612 Finished ✅ Results

@github-actions github-actions bot added the feature New feature or request label Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Uffizzi Preview deployment-56096 was deleted.

Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Other than that looks good, but I'd like to have some explanation on why users would want to have this enabled or not. There are also docs like https://docs.flagsmith.com/clients/#local-evaluation-1 that need to be updated to take into account this new setting, but we can add this in a different PR

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Sep 10, 2024

Good question as to why they'd want this enabled or not, I get the feeling that we'd start enabling this by default @gagantrivedi ?

The only reason I see this being useful as an option is if a project uses flags on the backend and frontend and want to reserve identity overrides for just development and never want it hitting their backend.

@gagantrivedi
Copy link
Member

Good question as to why they'd want this enabled or not, I get the feeling that we'd start enabling this by default @gagantrivedi ?

The only reason I see this being useful as an option is if a project uses flags on the backend and frontend and want to reserve identity overrides for just development and never want it hitting their backend.

The reasoning is captured here https://flagsmith.slack.com/archives/CTF0THS2D/p1725270568904189?thread_ts=1724865246.072169&cid=CTF0THS2D

@kyle-ssg
Copy link
Member Author

Ok yep, bringing here for visibility

This will mean that a release on our side might (probably will) change the value for flags in our customer’s environments. I actually think this should be an opt in flag on the environment, defaulted to true for all new environments, but off for any
existing ones.

So essentially this is to avoid any unexpected changes

@kyle-ssg
Copy link
Member Author

@rolodato based on this, should we just have a small note somewhere on this rather than having it be too prominent in docs ?

@rolodato
Copy link
Member

Let's merge this as-is and improve the docs later. Getting more people onboarded to this is more important than having perfect docs.

We'd need to share more detailed context in the docs by explaining that this is only for SaaS, was/will be enabled by default for all new environments since a specific Flagsmith version - too much to fit in a small note IMO.

Copy link

flagsmith bot commented Sep 10, 2024

Flagsmith feature linked: use_identity_overrides_in_local_eval
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-09-10 13:32:43
Staging ✅ Enabled 2024-09-10 13:32:32
Demo ❌ Disabled 2024-09-10 13:28:59
Self hosted defaults ❌ Disabled 2024-09-10 13:28:59

@kyle-ssg kyle-ssg added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit f8a048e Sep 10, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the feat/use_identity_overrides_in_local_eval branch September 10, 2024 20:54
Copy link

sentry-io bot commented Sep 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'use_identity_overrides_in_local_eval') apply(web/components/pages/EnvironmentSettingsP... View Issue

Did you find this useful? React with a 👍 or 👎

Copy link

flagsmith bot commented Sep 24, 2024

Flagsmith Feature use_identity_overrides_in_local_eval has been updated:

Environment Enabled Value Last Updated (UTC)
Demo ✅ Enabled 2024-09-24 16:35:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI(environment): Add toggle for use_identity_override_in_local_eval
3 participants