Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning): use transaction.atomic to prevent corrupt versions being created #4617

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Prevent versions from being persisted to the database if the request fails.

How did you test this code?

Updated an existing test.

@matthewelwell matthewelwell requested a review from a team as a code owner September 10, 2024 17:39
@matthewelwell matthewelwell requested review from zachaysan and removed request for a team September 10, 2024 17:39
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 10, 2024 5:39pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Sep 10, 2024 5:39pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Sep 10, 2024 5:39pm

@github-actions github-actions bot added the api Issue related to the REST API label Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4617 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4617 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4617 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4617 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4617 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4617 Finished ✅ Results

@github-actions github-actions bot added the fix label Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Uffizzi Preview deployment-56110 was deleted.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (1b22cf5) to head (362380c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4617   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files        1160     1160           
  Lines       40137    40159   +22     
=======================================
+ Hits        39000    39022   +22     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 7ac05cd Sep 11, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/ghost-versions-created-when-failure-occurs branch September 11, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants