Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve segment override UI #4633

Merged
merged 6 commits into from
Oct 1, 2024
Merged

feat: Improve segment override UI #4633

merged 6 commits into from
Oct 1, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 17, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Cleans up segment overrides / makes it more obvious what enabling / disabling here does.

Left: after, right: previous

image

How did you test this code?

  • Tested all actions
  • Viewed existing production examples of segment overrides
  • Viewed multivariate segment overrides

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 17, 2024 14:32
@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 5:47pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 5:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 5:47pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4633 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4633 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4633 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4633 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4633 Finished ✅ Results ✅

@kyle-ssg kyle-ssg changed the title style: Improve segment override UI feat: Improve segment override UI Sep 17, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Uffizzi Preview deployment-56356 was deleted.

@kyle-ssg kyle-ssg mentioned this pull request Sep 17, 2024
Merged
4 tasks
@kyle-ssg kyle-ssg requested a review from rolodato September 17, 2024 15:15
matthewelwell
matthewelwell approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually via the preview link, and reviewed the code as well as I can.

@kyle-ssg
Merge branch 'refs/heads/main' into style/segment-override-ui
2e75daf 
# Conflicts:
#	frontend/web/components/SegmentOverrides.js
@kyle-ssg
collapse id
003ed1e
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 1, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 1, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit a265d74 Oct 1, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the style/segment-override-ui branch October 1, 2024 17:55
@flagsmithdev flagsmithdev mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell