Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove trait #4686

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: remove trait #4686

merged 1 commit into from
Oct 2, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 2, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes remove trait, currently not working for edge identities due to a conflicting attribute name "id", a regression from https://github.com/Flagsmith/flagsmith/pull/4620/files#diff-ec3e6ef2e63b160e088c3ca802a58fef3c3b31616c7ad035faad3aa0b2ae14a2R307

How did you test this code?

Removed a trait in production

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 2, 2024 15:35
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:37pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 2, 2024 3:37pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4686 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4686 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4686 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4686 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4686 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4686 Finished ✅ Results ✅

@kyle-ssg kyle-ssg requested a review from matthewelwell October 2, 2024 15:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-56859

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4686

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 6dc8b7b Oct 2, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the fix/remove-trait branch October 2, 2024 15:41
@flagsmithdev flagsmithdev mentioned this pull request Oct 2, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Uffizzi Preview deployment-56859 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell