Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci hanging on md file changes #428

Closed
jjw24 opened this issue May 12, 2021 · 13 comments
Closed

Fix ci hanging on md file changes #428

jjw24 opened this issue May 12, 2021 · 13 comments
Labels
bug Something isn't working

Comments

@jjw24
Copy link
Member

jjw24 commented May 12, 2021

AppVeyor ci build hangs when only changes are MD files

@jjw24 jjw24 added the bug Something isn't working label May 12, 2021
@JohnTheGr8
Copy link
Member

We have configured AppVeyor to skip commits that only change markdown files, because building those isn't really necessary... Is this an issue?

@jjw24
Copy link
Member Author

jjw24 commented May 19, 2021

Yeah I think it is still an issue, will test later

@jjw24
Copy link
Member Author

jjw24 commented May 19, 2021

nop still no good
image

@jjw24
Copy link
Member Author

jjw24 commented May 19, 2021

image

@JohnTheGr8
Copy link
Member

I knew what you meant, you didn't need to test it... This is more or less expected behavior, AppVeyor never starts a build for these commits, and Github waits for a build success notification that never comes.

If you feel this is a big annoyance, we can remove the lines I mentioned earlier from appveyor.yml... Or you can use your superpowers to force merge such PRs, they only come once in a while anyway...

@jjw24
Copy link
Member Author

jjw24 commented May 20, 2021

If we remove that line, AppVeyor will build for md changes and return a status?

@jjw24
Copy link
Member Author

jjw24 commented May 20, 2021

Let's do that

@taooceros
Copy link
Member

Is it possible to simply return success when only md is changed is appveyor?

@JohnTheGr8
Copy link
Member

Is it possible to simply return success when only md is changed is appveyor?

Seems like there is no standard way to do that, no.

Let's do that

In my opinion this is a minor annoyance that happens rarely enough that it can be overlooked... it only affects PRs whose last commit changes markdown files only. By removing the skip of such commits, we will be stressing a free service unnecessarily on every commit that simply changes the Readme, etc. I think it's a small price to pay...

@jjw24
Copy link
Member Author

jjw24 commented May 20, 2021

yeah that's fine

@jjw24 jjw24 closed this as completed May 20, 2021
@taooceros
Copy link
Member

We can do something like this.
appveyor/ci#1848 (comment)

@taooceros taooceros reopened this Jul 19, 2021
@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 14, 2022
@jjw24 jjw24 removed the Stale label Jul 16, 2022
@deefrawley
Copy link
Member

Old issue with many CI updates since. If still a problem reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants