Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies
@compact
so that it no longer stores a string for each keyword argument. Like real keywords, they run once, and the resulting NamedTuple is all that remains.Instead, it proposes to print something like
summary(w)
for any array. Maybe this needs to be trimmed a bit, as for CuArray etc it can get quite long. Could trim it all the way to32×26 AbstractMatrix{Float32}
. This change should probably be made in Flux anyway (along with other fixes to how show handles arrays) so is just prototyped piratically here for now. [Edit: now https://github.com/FluxML/Flux.jl/pull/2344]