-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing implementations in StatsFuns #118
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 79.15% 78.72% -0.43%
==========================================
Files 24 24
Lines 753 752 -1
==========================================
- Hits 596 592 -4
- Misses 157 160 +3
Continue to review full report at Codecov.
|
Test errors are unrelated and exist on master as well. |
why StatFuns's functions allow for array input? |
They don't, but I didn't want to commit type piracy and hence removed the error message overloads for arrays for the functions implemented in StatsFuns. |
this shouldn't have any impact on zygote or gpu support, right? |
It shouldn't. I just tested it on a GPU, and the sigmoid function seems to be fine. The softplus function errored due to the use of There's actually an adjoint defined for |
This PR removes the implementations of the softplus and the logistic function from this package and uses the implementations in StatsFuns instead. It goes back to #98 (comment).