Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smart_field): don't try to compute smart fields on null relations #146

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix(smart_field): don't try to compute smart fields on null relations #146

merged 1 commit into from
Aug 17, 2023

Conversation

jbarreau
Copy link
Collaborator

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@jbarreau jbarreau requested a review from SteveBunlon August 17, 2023 08:31
@jbarreau jbarreau merged commit 33673a1 into main Aug 17, 2023
@jbarreau jbarreau deleted the fix_smart_field_on_null_relations branch August 17, 2023 14:07
forest-bot added a commit that referenced this pull request Aug 17, 2023
@forest-bot
chore(release): 1.6.8 [skip ci]
f025903 
## [1.6.8](v1.6.7...v1.6.8) (2023-08-17)

### Bug Fixes

* **smart_field:** don't try to compute smart fields on null relations ([#146](#146)) ([33673a1](33673a1))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveBunlon SteveBunlon SteveBunlon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbarreau @forest-bot @SteveBunlon