Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Github theme #115

Closed
Andrew-web-coder opened this issue May 21, 2021 · 4 comments
Closed

Broken Github theme #115

Andrew-web-coder opened this issue May 21, 2021 · 4 comments

Comments

@Andrew-web-coder
Copy link

Github theme is broken in v1.2.0

You can easily see that here - https://codesandbox.io/s/prism-react-renderer-example-forked-ws3pz?file=/src/Basic.js

And it works fine after changing to older versions.
@Andrew-web-coder Andrew-web-coder changed the title Broken Grithub theme Broken Github theme May 21, 2021
@kitten
Copy link
Contributor

kitten commented May 21, 2021

I've reverted PR #100 that changed the styles for now until I can check which changes from it are save to pick over: 0040cd4

@kitten kitten closed this as completed May 21, 2021
@lex111 lex111 mentioned this issue May 25, 2021
Closed
@Andrew-web-coder
Copy link
Author

But you did not release v.1.2.1 therefore it is still broken in npm

@kitten
Copy link
Contributor

kitten commented Jun 3, 2021

@Andrew-web-coder Nope, it's been definitely released on the day https://www.npmjs.com/package/prism-react-renderer/v/1.2.1

@Andrew-web-coder
Copy link
Author

Hmm, true, then I just do not understand why GitHub shows 1.2.0 as the Latest release - https://github.com/FormidableLabs/prism-react-renderer/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kitten @Andrew-web-coder