Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove theme dictionary hook #252

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Dec 9, 2024

Description

  • Allows SSR by removing state that can be derived, and by removing a useRef that isn't needed on stable reference

Fixes #251

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Demo app and a local nextjs app

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 3cfe239

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prism-react-renderer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nlkluth nlkluth requested a review from carbonrobot December 9, 2024 20:00
grammar,
language,
// prism is a stable import
prism,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since prism is being imported, it's stable and won't cause unnecessary recalculations. I tested this a bit by changing some state while prism was in the dependency array and the memoized function was not invoked again

@nlkluth nlkluth merged commit 53c411c into master Dec 9, 2024
1 check passed
@nlkluth nlkluth deleted the remove-theme-dictionary-hook branch December 9, 2024 22:39
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for React Server Components?
2 participants