Orientation 'right' not working with dates

[matejfalat]

The Problem

Setting orientation = "right" doesn't seem to work properly when values are date objects. Tick labels are moved to the right, but the axis remains on the left.

Reproduction

https://codesandbox.io/s/interesting-nova-q14s3v?file=/index.js

[zfrankdesign]

I think I am having a similar issue 😬 If I add enough padding on the right side things work, but that's not ideal. Also if I add left padding to the chart (having issue with x axis label getting rendered off the left of the chart x axis) sometimes the y axis gets rendered on the left side again...

[zfrankdesign]

The Problem

Setting orientation = "right" doesn't seem to work properly when values are date objects. Tick labels are moved to the right, but the axis remains on the left.

Reproduction

https://codesandbox.io/s/interesting-nova-q14s3v?file=/index.js

@matejfalat I seemed to get my padding and y axis orientation (on the right) problems working by converting the date values in my data to numbers i.e. new Date(date).setHours(0, 0, 0, 0) no clue why this works, but it seems to stop my y axis from rendering on the left

[scottarver]

Here is a fork of the codesandbox that shows it working and not working if you comment line 20

https://codesandbox.io/s/sleepy-orla-qjq68f?file=/index.js

[scottarver]

I've got it narrowed down to a Date equality bug.

victory/packages/victory-axis/src/helper-methods.tsx

Line 288 in bbc1e2a

origin.x === domain.x[0] || origin.x === domain.x[1]

Before	After