Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmlSafe From @ember/string Is Deprecated #164

Open
nadnoslen opened this issue Feb 11, 2021 · 3 comments
Open

htmlSafe From @ember/string Is Deprecated #164

nadnoslen opened this issue Feb 11, 2021 · 3 comments

Comments

@nadnoslen
Copy link
Contributor

Console deprecation warnings are now present with Ember-3.25 as htmlSafe should actually be imported via @ember/template.

Essentially replace: import { htmlSafe } from '@ember/string' with import { htmlSafe } from '@ember/template'

@nadnoslen
Copy link
Contributor Author

import { htmlSafe } from '@ember/template'; seems to have been around since Ember 3.8. No action required in this addon's README. Thanks for maintaining!

@nadnoslen
Copy link
Contributor Author

Looks like this will still be a problem until this is resolved? 🤷‍♂️

emberjs/ember.js#19393

@nadnoslen
Copy link
Contributor Author

Note from core team here: https://discuss.emberjs.com/t/fixing-htmlsafe-and-ishtmlsafe-deprecation/18639/2

Upgrading to Ember 3.25.2 should turn down that deprecation noise:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant