Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Sharp styles #228

Open
robmadole opened this issue Apr 12, 2023 · 2 comments
Open

Add support for new Sharp styles #228

robmadole opened this issue Apr 12, 2023 · 2 comments

Comments

@robmadole
Copy link
Member

In PR #213 we added support for Sharp Solid. We now have Sharp Regular and Sharp Light.

Let's use #213 as a template and add the newer styles.

@deathnfudge
Copy link
Member

As part of this work, we should look at adding support for sharp-duotone styles as they come out.

@mkszepp
Copy link
Contributor

mkszepp commented Oct 27, 2024

@robmadole i have prepared a PR to migrate this addon to v2...
When we are getting that, we don't need anymore todo this changes in future when FA is adding new packages... the move to v2 addon is braking, but solves a lot of maintainence costs.
See #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants