Update addon to ember 4.12 #234
Conversation
| @@ -3,7 +3,7 @@ | |||
| "packages": [ | |||
| { | |||
| "name": "ember-cli", | |||
| "version": "3.28.2", | |||
There was a problem hiding this comment.
Can you run the updated to target 4.12.2 (the latest 4.12 release).
tests/dummy/config/ember-try.js
Outdated
| }, | ||
| }, | ||
| { | ||
| name: 'ember-lts-3.28', |
There was a problem hiding this comment.
We can make this a major release and drop support for these unsupported ember versions, testing should start at 4.4. If it happens to work for older ember that's ok too, but we don't need to guarantee, or test for, support.
There was a problem hiding this comment.
Okay, we ca do it... my plan was to make nothing braking, bacause, so we can fix FA5 at least in v1.0, beause all latest versions of this addon do not anymore support FA5.
Do you prefer to make brakingand bring back the support of FA5 in v2?
There was a problem hiding this comment.
This is a major version bump as is because of the node drop. So it can't really go into v1 anyway.
There was a problem hiding this comment.
Okay, i will try to make all changes tomorow
README.md
Outdated
There was a problem hiding this comment.
Should bump minimum ember and CLI to 4.4, node to 14.
There was a problem hiding this comment.
When we make braking, we should also drop node v14, as there is no longer lts
There was a problem hiding this comment.
I hear that, but I'm trying to take it slow and go to ember 4.12 and stick to that blueprint which includes node 14. Then when we bump up to the LTS in the 5.x series we can drop node 14.
* drop support for node < 14 * drop support for ember < 4 * remove ember-try scenarios
|
@jrjohnson while i have tested the switch from npm to pnpm i have found out, that the addons is using Now i have added in the dependency. |
# Conflicts: # .github/workflows/ci.yml # package-lock.json # package.json # tests/integration/components/fa-icon-test.js
|
@jrjohnson thanks for merging the fix for FA5, i have now also resolved all merge conflicts for this update, so we can also merge this one, after the release of the fix in v1 |
# Conflicts: # package-lock.json # package.json
|
seen, that there is again a merge conflicts. idk why this was updated in release commit (e3533ba#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R104): ember-fontawesome/package.json Line 104 in e3533ba @jrjohnson now we can merge this PR |
|
Thanks so much for getting all of this done @mkszepp, I really appreciate all the work you put in! I'm back from vacation and I merged this and requested a 2.0.0 release from the FA team. I also pinged them about the weird ember-source change in the last release. |
* Update addon to ember 4.12 * Fix prettier * add overrides to fix release, beta & canary * Update ember-cli to latest v4.12 * drop support for node < 14 * drop support for ember < 4 * remove ember-try scenarios * Fix ci * Add ember try for ember 5 * Update dependencies (ember-ast-helpers & glob) * Add missing dependency array-unique * Remove overrides & add buildManagerOptions in ember-try * fix lint --------- Co-authored-by: Markus Sanin <[email protected]>
|
Really appreciate all of your work on this @mkszepp, 2.0.0 was release today! |
|
@jrjohnson thanks 4 release! ❤️ |
ember-ast-helpers&globarray-uniquein dependency