Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise forking #28

Closed
FrameMuse opened this issue Feb 8, 2023 · 0 comments
Closed

Revise forking #28

FrameMuse opened this issue Feb 8, 2023 · 0 comments
Assignees
Milestone

Comments

@FrameMuse
Copy link
Owner

FrameMuse commented Feb 8, 2023

Solutions

fork as parameter

Passing fork as a param in open method will place a new modal in a forkedQueue so it can be open above all others.

fork as method

Not much thought about

fork as a new instance of ModalController class

By creating ModalController instance, it will be possible to create a new forked branch of modals.
Modal windows can be open with a standalone instance of ModalController.

const modalForked = new ModalController()

fork as a layer concept ✅

Provide a new layer for each modal window independently. Which can be automatically chosen by forking (somehow) or putting it manually (e.g. in params in open method as layer).

Modal.open(MyComponent, { layer: 3 })
@FrameMuse FrameMuse mentioned this issue Feb 8, 2023
6 tasks
@FrameMuse FrameMuse changed the title Make fork param a method. Revise forking Feb 8, 2023
@FrameMuse FrameMuse self-assigned this Feb 9, 2023
@FrameMuse FrameMuse added this to the Planned milestone Feb 11, 2023
@FrameMuse FrameMuse modified the milestones: Planned, v1.2.0 Feb 22, 2023
@FrameMuse FrameMuse linked a pull request Mar 22, 2023 that will close this issue
@FrameMuse FrameMuse modified the milestones: v1.2.0, Planned Mar 25, 2023
@FrameMuse FrameMuse modified the milestones: Planned, v2.0.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant