Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md is quite unclear #5

Closed
2 tasks done
Tracked by #6
FrameMuse opened this issue Jul 29, 2022 · 1 comment · Fixed by #44
Closed
2 tasks done
Tracked by #6

README.md is quite unclear #5

FrameMuse opened this issue Jul 29, 2022 · 1 comment · Fixed by #44
Assignees
@FrameMuse
Labels
documentation Improvements or additions to documentation

Comments

@FrameMuse
Copy link
Owner

FrameMuse commented Jul 29, 2022 •
edited
Loading

README.md should include
@FrameMuse FrameMuse added the documentation Improvements or additions to documentation label Jul 29, 2022
@FrameMuse FrameMuse self-assigned this Jul 29, 2022
@FrameMuse FrameMuse modified the milestone: v0.9.18 Jul 29, 2022
@FrameMuse FrameMuse mentioned this issue Jul 29, 2022
Closed
6 tasks
@FrameMuse
Copy link
Owner Author

FrameMuse commented Jul 29, 2022 •
edited
Loading

Describe Motivation better

  • It has unclarity in unwanted overlaping
  • Could be mentioned the advantage that it doesn't require creating a react context or anything to open a modal from another component.
  • Could be mentioned the advantage that it relies completely on react tree rendering not on setAppElement as for react-modal

Repository owner locked and limited conversation to collaborators Jul 29, 2022
@FrameMuse FrameMuse linked a pull request Feb 12, 2023 that will close this issue
Make README.md more clear #44
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@FrameMuse FrameMuse

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make README.md more clear FrameMuse/react-modal-global
1 participant
@FrameMuse