Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of Ship workbench #31

Open
1 of 2 tasks
luzpaz opened this issue Oct 21, 2021 · 18 comments
Open
1 of 2 tasks

Translation of Ship workbench #31

luzpaz opened this issue Oct 21, 2021 · 18 comments
Assignees
Labels
enhancement New feature or request

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Oct 21, 2021

  • Add translation infrastructure
  • Hook in to crowdin

ref: FreeCAD/FreeCAD-addons#187

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 18, 2022

Maybe we can get this going as well...now that we're in a feature freeze and there are a translators active in crowdin?

@sanguinariojoe
Copy link
Collaborator

No idea if there are translators indeed. I remember i did some changes to make ship translatable. But probably I am still missing some stuff

@sanguinariojoe
Copy link
Collaborator

Ok, I followed the guideline, so the file resources/translation/Ship.ts is ready to be uploaded to your FreeCAD Crowdin account.

Shall I add a topic on the forum? Ping Yorik here?

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 19, 2022

I got it from here 👍
Thank you!

@darigovresearch
Copy link
Contributor

Is there anything left to get translation hooked into crowdin?

@sanguinariojoe
Copy link
Collaborator

ping @luzpaz

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 29, 2022

@yorikvanhavre (this is regarding adding the ShipWB addon to crowdin)

@luzpaz
Copy link
Contributor Author

luzpaz commented May 8, 2023

@yorikvanhavre how are we doing this again (3rd party addons + crowdin) ?

@yorikvanhavre
Copy link
Member

Oops sorry all, I was sure we had done this already 😓

@sanguinariojoe I need to give you "maintainer" status on crowdin so you can upload files there. Could you create yourself an account and translate a few strings on https://crowdin.com/project/freecad-addons ?

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 10, 2024

@hasecilu
Copy link
Contributor

Isn't already translated? I'm having problems loading the WB now on latest v. I'll try an older AppImage later and check it.

@sanguinariojoe
Copy link
Collaborator

Isn't already translated? I'm having problems loading the WB now on latest v. I'll try an older AppImage later and check it.

After your changes I have fixed the resources and some other minor related things. It should be working fine now

@hasecilu
Copy link
Contributor

hasecilu commented Sep 12, 2024

I can confirm that is now working on latest version (self-compiled with Qt6 support).

@sanguinariojoe since you know more than me of this subject, will you be interested on finish the translation (either on CrowdIn or locally with Qt Linguist)? There are few terms that I don't know I don't want to mess it up.

@sanguinariojoe
Copy link
Collaborator

I can confirm that is now working on latest version (self-compiled with Qt6 support).

@sanguinariojoe since you know more than me of this subject, will you be interested on finish the translation (either on CrowdIn or locally with Qt Linguist)? There are few terms that I don't know I don't want to mess it up.

Done!

@hasecilu
Copy link
Contributor

hasecilu commented Sep 13, 2024

Done!

Looks pretty good! Now compiling the translation files with lrelease is enough for the UI to be translated.

I have seen the term "ship" being translated as "barco", "buque" and "nave", which should be the preferred term? maybe "nave" to match with "diseño naval"? Also "tank": "tanque" or "depósito"?

@sanguinariojoe
Copy link
Collaborator

Done!

Looks pretty good! Now compiling the translation files with lrelease is enough for the UI to be translated.

I have seen the term "ship" being translated as "barco", "buque" and "nave", which should be the preferred term? maybe "nave" to match with "diseño naval"? Also "tank": "tanque" or "depósito"?

"Buque" is clearly the most appropriate term.

"Barco" is rather common though, but a bit less technical. "Nave" is usually applied to speak about really old ships, and I think is common on South America. A rather more appropriate variant of "nave" would be "navío".

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 23, 2024

What's left here ?

@hasecilu
Copy link
Contributor

hasecilu commented Sep 23, 2024

Finish translations and merge them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants