Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Softcode strumline fade in to be disabled by modules #2616

Open
manyshrimp opened this issue May 27, 2024 · 0 comments
Open

Enhancement: Softcode strumline fade in to be disabled by modules #2616

manyshrimp opened this issue May 27, 2024 · 0 comments
Labels
status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.

Comments

@manyshrimp
Copy link

As it currently stands, the code that runs fadeInArrows() on both strumlines is only dictated by PlayStatePlaylist.isStoryMode, as seen in this snippet from PlayState in initStrumlines():

if (!PlayStatePlaylist.isStoryMode)
{
  playerStrumline.fadeInArrows();
  opponentStrumline.fadeInArrows();
}

Due to the nature of tweens and the fact that this runs immediately on creation of the state, changing the individual position of notes within the strumline is difficult or, at the very least, inconvenient. I feel as though it would make more sense for this animation to occur when the countdown starts, with a public boolean to disable/skip it, to allow modders to more easily reposition arrows or implement their own animation that doesn't conflict with the original one. I would make this a pull request, but I'm not confident enough in my programming abilities for that. Someone else very easily could, however.

@manyshrimp manyshrimp added the type: enhancement Involves an enhancement or new feature. label May 27, 2024
@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. and removed type: enhancement Involves an enhancement or new feature. labels Jun 17, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
@AbnormalPoof AbnormalPoof added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

3 participants