Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Remove certain traces during charting #2649

Open
tposejank opened this issue Jun 4, 2024 · 3 comments
Open

Enhancement: Remove certain traces during charting #2649

tposejank opened this issue Jun 4, 2024 · 3 comments
Labels
status: planned Planned to be implemented some time in the future. type: optimization Involves a performance issue or a bug which causes lag.

Comments

@tposejank
Copy link
Contributor

Please check for duplicates or similar issues before creating this issue.

What is your suggestion, and why should it be implemented?

While charting, if an event without an image or whatever is near, this will be printed every frame:
source/funkin/ui/debug/charting/components/ChartEditorEventSprite.hx:130: Warning: Invalid animation name "MIDI Event" for song event. Using "Default"
This causes more lag than anything running in the background, specially for me which i am using the compiled build from the cmd.

Thanks

@tposejank tposejank added the type: enhancement Involves an enhancement or new feature. label Jun 4, 2024
@tposejank
Copy link
Contributor Author

Recording.2024-06-04.163339.mp4

Video demonstration

Copy link
Member

yeowch! will put this one on our task list!

@EliteMasterEric EliteMasterEric added type: optimization Involves a performance issue or a bug which causes lag. status: reviewing internally Under consideration and testing. status: pending triage Awaiting review. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed Optimization type: enhancement Involves an enhancement or new feature. status: reviewing internally Under consideration and testing. status: pending triage Awaiting review. labels Jun 16, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
@AbnormalPoof
Copy link
Collaborator

I don't seem to be getting severe lag like the video shows, so I'd assume this is fixed. The line is still there however, so I'll leave this issue open until there's confirmation that the lag is gone.

@Hundrec Hundrec added status: planned Planned to be implemented some time in the future. and removed status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned Planned to be implemented some time in the future. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Development

No branches or pull requests

5 participants