Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: enabling practice mode when starting a freeplay song and spamming arrow keys or wasd it stops everything like no music and the notes stop in place #2732

Open
crazyj3re opened this issue Jun 9, 2024 · 10 comments
Labels
status: cannot reproduce Involves a bug which cannot be reliably reproduced by reviewers. Assistance may be needed. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Comments

@crazyj3re
Copy link

crazyj3re commented Jun 9, 2024

Describe the bug

the bug is that when enabling practice mode when starting a freeplay song and spamming arrow keys or wasd it stops everything like no music and the notes stop in place

To Reproduce

start a freeplay song and turn on practice mode and try and spam arrow keys or wasd

Expected behavior

not sure

Screenshots/Video

WIINDOWS 11

  • Browser
  • Version:

v0.4.0

Additional context

@crazyj3re crazyj3re added the type: minor bug Involves a minor bug or issue. label Jun 9, 2024
Copy link
Member

hmmm I haven't been able to replicate. I'm on Mac as of writing/testing, when I get back to my windows PC I'll do another test. Maybe it's just quirky windows !

@ninjamuffin99 ninjamuffin99 changed the title Bug Report: [practice mode bug] Bug Report: enabling practice mode when starting a freeplay song and spamming arrow keys or wasd it stops everything like no music and the notes stop in place Jun 9, 2024
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Jun 9, 2024

I'm on Windows 11 too but also couldn't replicate

@Hundrec
Copy link
Collaborator

Hundrec commented Jun 9, 2024

Also couldn't replicate on Windows 11
Maybe it's a performance-related bug?

@crazyj3re
Copy link
Author

i got a video of it happening!

2024-06-09.19-39-30.mp4

@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. status: cannot reproduce Involves a bug which cannot be reliably reproduced by reviewers. Assistance may be needed. and removed Needs Verification type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. labels Jun 16, 2024
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Jun 24, 2024

Managed to reproduce this on browser! Seems to be related to #2901

Edit: Managed to reproduce in Desktop version too.

@EliteMasterEric
Copy link
Member

Still haven't been able to reliably reproduce this particular issue (I can't seem to spam as fast as you're doing in the video?) but I have a theory:

The audio system has a hard cap of 32 sound channels. If a sound attempts to play while the audio system is capped, it won't play, and this can cause the instrumental to not start. If the instrumental doesn't start, that breaks the Conductor and therefore all the gameplay logic.

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Sep 11, 2024

Reproduced on macOS. You have to spam really fast (spamming WASD and the arrow keys helps)!

audio.spam.bug.mp4

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Sep 11, 2024

The audio system has a hard cap of 32 sound channels. If a sound attempts to play while the audio system is capped, it won't play, and this can cause the instrumental to not start. If the instrumental doesn't start, that breaks the Conductor and therefore all the gameplay logic.

That's very plausible since when I was trying to reproduce it sometimes one of the vocals would permanently stop playing instead.

In this video I managed to break both(?) vocals

8mb.video-TX1-mIt6Smk8.mp4

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Oct 8, 2024

If a sound attempts to play while the audio system is capped, it won't play, and this can cause the instrumental to not start.

Would it be possible to "queue" the sound to play the next time a sound channel is available if it's capped? Worst case scenario it delays the instrumental/song starting. (At least in theory?)

@AbnormalPoof AbnormalPoof marked this as a duplicate of #2901 Jan 22, 2025
@github-actions github-actions bot marked this as not a duplicate of #2901 Jan 22, 2025
@Hundrec Hundrec marked this as a duplicate of #2901 Jan 22, 2025
@Lasercar
Copy link
Contributor

I wonder, is there a way a sound channel can be reserved for the instrumental and vocals? That'd be the best/easiest way to fix this, other than what poof stated above.

Also, why does this have the cannot reproduce label?

@AbnormalPoof AbnormalPoof added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression and removed type: minor bug Involves a minor bug or issue. labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: cannot reproduce Involves a bug which cannot be reliably reproduced by reviewers. Assistance may be needed. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Development

No branches or pull requests

7 participants