Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Opponent stops singing on miss when bf has no vocals file #2837

Open
IDiMooo opened this issue Jun 17, 2024 · 2 comments
Open

Bug Report: Opponent stops singing on miss when bf has no vocals file #2837

IDiMooo opened this issue Jun 17, 2024 · 2 comments
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: minor bug Involves a minor bug or issue.

Comments

@IDiMooo
Copy link

IDiMooo commented Jun 17, 2024

Describe the bug

When there is only one vocal file for opponent and not for boyfriend, this audio will stop play on miss even if it's not bf's vocal file.

To Reproduce

Create a song with only one vocal file for opponent and miss a note before opponent's turn.

Expected behavior

The audio should still play if I understand why the vocals were seperated.

Screenshots/Video

image

2024-06-17.16-09-15.-.Trim.online-video-cutter.com.mp4

Desktop

  • OS: Windows 10
  • Browser: nope
  • Version: 0.4.1

Additional context

I was porting some mods and they have the old Voices files so I just wanted to give it to opponent so it won't mute and the miss sounds will be the only thing but I noticed that even if the voices are on the opponent's side they still get muted after miss. If both vocal files are there it mutes just bf's but if there is one for opponent it mutes it too. I don't know if it is intented but ye.

@M7theguy
Copy link

This is the reason why they seperated the vocals. The mod you are playing only has one file for vocals of the opponent AND Boyfriend. A fix for this might be to check how many vocal files there are and shorten the miss effect

@IDiMooo
Copy link
Author

IDiMooo commented Jun 17, 2024

Yeah I get why they seperated the files it's just the fact that bf can mute opponents side in this case which i think may not be intended

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jun 25, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

4 participants