Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Changelog Fixing #3676

Closed
2 tasks done
JVNpixels opened this issue Oct 12, 2024 · 5 comments · Fixed by #3655
Closed
2 tasks done

Enhancement: Changelog Fixing #3676

JVNpixels opened this issue Oct 12, 2024 · 5 comments · Fixed by #3655
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: documentation Involves improvements or additions to documentation.
Milestone

Comments

@JVNpixels
Copy link
Contributor

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

Basically just add the new contributors section to 0.5.0 and 0.5.1 since it feels weird and I wanna see who contributed, and the format doesn’t really fit with the other changelog sections.

@JVNpixels JVNpixels added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Oct 12, 2024
@JVNpixels
Copy link
Contributor Author

This will probably not be added due to it being older updates, but I just thought that it would be a good idea.

@Cartridge-Man
Copy link
Contributor

Have you stopped to think it might not exist in those because nobody new contributed to those updates?

@JVNpixels
Copy link
Contributor Author

Have you stopped to think it might not exist in those because nobody new contributed to those updates?

I contributed in 0.5.0, so I am wondering, and I am pretty sure in 0.5.1 there was new contributors.

@Hundrec
Copy link
Collaborator

Hundrec commented Oct 13, 2024

I did some of this in #3655 right after 0.5.2 released, and then Eric did his own rewrite that conflicted with mine (lol)

@Hundrec
Copy link
Collaborator

Hundrec commented Oct 13, 2024

Alright, I've done a bunch more linking all the way back to 0.3.3
That includes highlighting your first contribution in 0.5.0, @JVNpixels!

@EliteMasterEric EliteMasterEric added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Oct 15, 2024
@Hundrec Hundrec added status: resolved The issue has been fixed or the suggestion has been implemented. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending pull request Dependent on a pull request that is currently awaiting review. labels Jan 22, 2025
@Hundrec Hundrec added type: documentation Involves improvements or additions to documentation. status: resolved The issue has been fixed or the suggestion has been implemented. and removed status: resolved The issue has been fixed or the suggestion has been implemented. type: enhancement Involves an enhancement or new feature. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. labels Jan 22, 2025
@Hundrec Hundrec added this to the 0.5.2 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: documentation Involves improvements or additions to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants