Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Remove 0.5sec of input ignoring when entering pause menu #3709

Closed
2 tasks done
DemiSans opened this issue Oct 15, 2024 · 15 comments
Closed
2 tasks done

Enhancement: Remove 0.5sec of input ignoring when entering pause menu #3709

DemiSans opened this issue Oct 15, 2024 · 15 comments
Labels
status: resolved internally Completed development and will be released some time in the future. type: enhancement Involves an enhancement or new feature.

Comments

@DemiSans
Copy link

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

That wasnt a thing before weekend 1 update :(

@DemiSans DemiSans added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Oct 15, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Oct 15, 2024

I think disabling pause spamming prevents some bugs from occurring, but I'm open to hearing out why you want it back.
What would you want to do with it?

@DemiSans
Copy link
Author

@Hundrec I want to fast restart the song by pressing enter, ↓, enter, but I cant bc ↓ didnt register and instead im pressing "resume".

And overall, just qol improvement. For navigating in pause menu instantly, without waiting.

@Hundrec
Copy link
Collaborator

Hundrec commented Oct 15, 2024

I see, that's a pretty good purpose! Maybe they can find a compromise between disabling inputs and allowing quick restarts.
One idea I have is making the RESET keybind work in the pause menu, instantly restarting the song (as many people have requested)

@amyspark-ng
Copy link
Contributor

amyspark-ng commented Oct 16, 2024

I see, that's a pretty good purpose! Maybe they can find a compromise between disabling inputs and allowing quick restarts. One idea I have is making the RESET keybind work in the pause menu, instantly restarting the song (as many people have requested)

i remember asking for it but i think they denied it and instead send me a script that i use to today

@Average-FNF-Modder
Copy link

I see, that's a pretty good purpose! Maybe they can find a compromise between disabling inputs and allowing quick restarts. One idea I have is making the RESET keybind work in the pause menu, instantly restarting the song (as many people have requested)

i remember asking for it but i think they denied it and instead send me a script that i use to today

Be a G and pass the script around to the class.

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Oct 16, 2024

Be a G and pass the script around to the class.

#2442 (comment)

@Average-FNF-Modder
Copy link

I see, that's a pretty good purpose! Maybe they can find a compromise between disabling inputs and allowing quick restarts. One idea I have is making the RESET keybind work in the pause menu, instantly restarting the song (as many people have requested)

i remember asking for it but i think they denied it and instead send me a script that i use to today

Be a G and pass the script around to the class.

#2442 (comment)

Thank you fr.

@amyspark-ng
Copy link
Contributor

amyspark-ng commented Oct 16, 2024

import funkin.modding.module.Module;
import funkin.play.PlayState;

import funkin.play.PauseSubState;
import funkin.play.PauseMode;

import funkin.ui.freeplay.FreeplayState;
import flixel.FlxG;
import funkin.audio.FunkinSound;

class QuickReset extends Module {
	function new() {
		super('QuickReset');
	}

	function onUpdate(event) {
		if (PlayState.instance != null) {
			if (FlxG.keys.pressed.CONTROL) {
				if (FlxG.keys.justPressed.R) {
					PlayState.instance.needsReset = true;

					// is paused
					if (PlayState.instance.subState != null) {
						PlayState.instance.closeSubState();
					}
				}
			}
		}
	}
}

i modified it so it also works if the game is paused

@amyspark-ng
Copy link
Contributor

if you want to change the key just replace the FlxG.keys.justPressed.R with the key you want

@M7theguy
Copy link

where do I add the code to make it work?

@amyspark-ng
Copy link
Contributor

where do I add the code to make it work?

you have to make a .hxc file and place it in a folder in mods so like

funkin/mods/quickreset/reset.hxc

@ninjamuffin99 ninjamuffin99 self-assigned this Dec 9, 2024
Copy link
Member

very nice suggestion, when this is issue gets closed, it means it's merged internally, thanks!

@ninjamuffin99 ninjamuffin99 removed the status: pending triage Awaiting review. label Dec 9, 2024
@ninjamuffin99 ninjamuffin99 added the status: resolved The issue has been fixed or the suggestion has been implemented. label Dec 9, 2024 — with Linear
@github-actions github-actions bot closed this as completed Dec 9, 2024
@ninjamuffin99 ninjamuffin99 removed the status: resolved The issue has been fixed or the suggestion has been implemented. label Dec 9, 2024
@ninjamuffin99 ninjamuffin99 reopened this Dec 9, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Dec 9, 2024

Sorry @ninjamuffin99, I messed something up!
Can you create a new label called status: resolved internally?

@ninjamuffin99 ninjamuffin99 added the status: resolved internally Completed development and will be released some time in the future. label Dec 9, 2024
@ninjamuffin99
Copy link
Member

hundrec you devil

@Hundrec
Copy link
Collaborator

Hundrec commented Dec 9, 2024

Bahaha, looks like my actions system needs some more work!

I'll make a couple labels suggestions in a new issue for you and Eric to look over.
Hopefully that will make things easier to use :)

It's ready! #3920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved internally Completed development and will be released some time in the future. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

7 participants