Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: detect and register fnfc from assets and/or let scripts initialize playstate from fnfc #4024

Closed
2 tasks done
cyn0x8 opened this issue Jan 23, 2025 · 3 comments
Closed
2 tasks done
Labels
status: duplicate Issue or PR is redundant to another.

Comments

@cyn0x8
Copy link
Contributor

cyn0x8 commented Jan 23, 2025

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

while fnfc contains all the resources for a song, theres currently no way for PlayState be initialized from it except via the chart editor

itd be nice if we could initialize PlayState or create a Song from an fnfc file, and/or just put it into the songs or data/songs folder under the respective song id and have the game recognize it and add it to the registry, instead of having to extract its contents to the right places

@cyn0x8 cyn0x8 added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jan 23, 2025
@cyn0x8 cyn0x8 changed the title Enhancement: let scripts initialize playstate from fnfc and/or detect fnfc from assets Enhancement: detect and register fnfc from assets and/or let scripts initialize playstate from fnfc Jan 23, 2025
@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Jan 23, 2025

Are you asking for scripts to be able to load songs from .fnfc files? If so, then this sounds similar to #2363.

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Jan 23, 2025

Are you asking for scripts to be able to load songs from .fnfc files? If so, then this sounds similar to #2363.

yes
the wording is a bit imprecise because i meant generally and not just freeplay/story mode, but im assuminggg solving their issue entails "detect and add fnfc to song registry" which would solve this issue as well

@cyn0x8 cyn0x8 closed this as completed Jan 23, 2025
@AbnormalPoof AbnormalPoof added the status: duplicate Issue or PR is redundant to another. label Jan 23, 2025
Copy link

This issue is a duplicate. Please direct all discussion to the original issue.

@github-actions github-actions bot removed the status: pending triage Awaiting review. label Jan 23, 2025
@AbnormalPoof AbnormalPoof removed the type: enhancement Involves an enhancement or new feature. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate Issue or PR is redundant to another.
Projects
None yet
Development

No branches or pull requests

2 participants