Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Enhancements Mega Issue? #4066

Closed
2 of 3 tasks
Lasercar opened this issue Jan 30, 2025 · 6 comments
Closed
2 of 3 tasks

Minor Enhancements Mega Issue? #4066

Lasercar opened this issue Jan 30, 2025 · 6 comments
Labels
status: rejected Issue did not pass review or PR cannot be approved.

Comments

@Lasercar
Copy link
Contributor

Lasercar commented Jan 30, 2025

Issue Checklist

  • I have read the pinned Issues Guide
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested
  • I have properly named my enhancement

What is your suggestion, and why should it be implemented?

There's going to be a lot of minor enhancements suggested that don't really each need a separate issue, for example:
Enhancement: Remove the first frame of Pico's explosion gameover: #4060
Make only long hold notes have transparency: #2893 (comment) deleted and moved to a separate issue: #4070

Plus, this minor enhancements mega issue could double as a place to put all those question suggestions in, for example:
Have you considered making Psychic (from the mind games mod) an opponent? In my opinion, he fits in way too well with the rest of the characters and has some interesting song events too. He's just too cool to simply remain a mod character, though if not, then adding a reference to either him or the engine itself would be funkin cool too.

This mega issue idea might end up being like some kind of forum topic/post too. I'm sure many of here would like everyone to return to using forums rather than social media (or maybe only me because I don't have any)

If you like idea of making a mega issue for all the minor enhancements and such, either make this the mega issue and edit my message here or simply make a new issue for it.

Off-topic (issue?) thing
Also, I just have to mention this thought so I can get out of my mind and stop thinking about it - the weekend one stage reminds me of this UT3 map:
https://unreal.fandom.com/wiki/WAR-Downtown
It's gives off the exact same vibe even though the stage isn't inspired by the UT3 map at all and I find that fascinating. The dynamic music for the map doesn't sound anything like the weekend one songs though, but it does really match the vibe of the map (and stage), especially so for the suspense track:
https://downloads.khinsider.com/game-soundtracks/album/unreal-tournament-3-ps3-windows-xbox-360-gamerip-2007/159%2520Strident%25206.mp3

That, and blazin sounds a lot like the soundtrack used in this custom UT3 map. I don't know where it's from though:
https://www.youtube.com/watch?v=7jyOpa-PwpA&t=155s

@Lasercar Lasercar added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jan 30, 2025
@KoloInDaCrib
Copy link
Contributor

In an enhancement issue that contained a lot of minor enhancements, Eric said this:
Image

Also, say, only a few enhancements from a mega enhancement issue get completed - should the entire issue get closed then? If not then there would need to be a checklist in the mega enhancement issue so that the members could check off what was completed. However what if some of the enhancement ideas get rejected? To put it simply - it would be a nightmare to deal with

@AbnormalPoof
Copy link
Collaborator

Please make individual issues for these, one big issue with a lot a things makes it a nightmare for the maintainers to review.

@AbnormalPoof AbnormalPoof added status: rejected Issue did not pass review or PR cannot be approved. and removed type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels Jan 30, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
@moxie-coder
Copy link

also jesus christ light mode

@Lasercar
Copy link
Contributor Author

Lasercar commented Jan 31, 2025

In an enhancement issue that contained a lot of minor enhancements, Eric said this:

Also, say, only a few enhancements from a mega enhancement issue get completed - should the entire issue get closed then? If not then there would need to be a checklist in the mega enhancement issue so that the members could check off what was completed. However what if some of the enhancement ideas get rejected? To put it simply - it would be a nightmare to deal with

Please make individual issues for these, one big issue with a lot a things makes it a nightmare for the maintainers to review.

So, I should make an issue for each suggestion there the two that don't have an issue, except for the offtopic thing I wanted to mention?

also jesus christ light mode

oi, I use light mode too - I'd rather be constantly reminded why my eyes feel strained (hint - it's because I'm staring into a screen, not because it's in light mode) rather than using dark mode on everything as if that'll somehow stop the screen from beaming light into my tired eyes late at night.

@Hundrec
Copy link
Collaborator

Hundrec commented Jan 31, 2025

Yes, please post each suggestion as its own issue while following all of the checklist steps.

@Lasercar
Copy link
Contributor Author

Lasercar commented Jan 31, 2025

Hmm, maybe I should question suggestion idea (adding in psychic from mind games either as an opponent or just a simple reference) into the discussions instead?
https://github.com/FunkinCrew/Funkin/discussions/categories/ideas
Or it it better to make it an issue?

Hmm, I guess I'll make it an issue. I mean, it was the mod that led to the psyh engine, after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

No branches or pull requests

5 participants