-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: The train sound effect in the Pico remixes of the Pico songs doesn't pause when the song is paused #4054
Bug Report: The train sound effect in the Pico remixes of the Pico songs doesn't pause when the song is paused #4054
Comments
This bug has been a thing for as long as I can remember, but I don't think anyone's reported it yet. |
Here are some videos demonstrating this bug. Looks like the train sound doesn't pause any time the Philly erect stage is used. Normalnormal.train.sound.mp4Erect (bugged)bugged.train.sound.mp4 |
Seems like it's very easy to fix, these functions are in public override function onPause(event:PauseScriptEvent) {
super.onPause(event);
// Temporarily stop ambiance.
if (trainSound != null) trainSound.pause();
}
public override function onResume(event:ScriptEvent) {
super.onResume(event);
// Temporarily stop ambiance.
if (trainSound != null) trainSound.resume();
} |
Just wanted to add to this issue that the same thing happens with the lightning strikes in the new difficulty and pico versions of the two Skid and Pump songs. |
Hm, sounds like something @NotHyper-474 could add to the PR |
I may have come up with a better solution that automatically pauses/resumes every sound instead of having to manually handle it through the stage script. When I have battle-tested it enough I might make a PR on this repo.
Now that I think about it you might be talking about the lightning itself and not the sound, althought it happens with the sound as well, perhaps a bit out of scope for that PR. |
I was talking about both? |
Anyway, I think I found a way to fix both, although I'm not sure if it's safe since it requires pausing every currently active tween, whereas the original code only pauses some of them. At the moment it doesn't seem to break anything, but just in case I'll still make the PR only pause sounds. 2025-01-28.16-04-32.mp4 |
They also need to fix the issue where the train sound occasionally doesn’t play on the normal stage. |
Same thing also happens in Mommy Mearest songs with the car - except that the car sprite in the normal versions of the song actually pauses, though the sound doesn't, but then disappears once the sound effect finishes playing while the game's paused. |
This issue is a duplicate. Please direct all discussion to the original issue. |
Issue Checklist
Platform
Itch.io (Downloadable Build) - Windows
Version
0.5.3
Description (include any images, videos, errors, or crash logs)
The train sound effect in the Pico remixes of the Pico songs doesn't pause when the song is paused (surely there's a better way to phrase this bug... but I can't think of one right now). This only happens in the Pico remixes - it doesn't happen in the regular/boyfriend song.
Steps to Reproduce
The text was updated successfully, but these errors were encountered: