Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: The train sound effect in the Pico remixes of the Pico songs doesn't pause when the song is paused #4054

Closed
2 tasks done
Lasercar opened this issue Jan 27, 2025 · 11 comments · May be fixed by FunkinCrew/funkin.assets#110
Labels
status: duplicate Issue or PR is redundant to another.

Comments

@Lasercar
Copy link
Contributor

Lasercar commented Jan 27, 2025

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Downloadable Build) - Windows

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

The train sound effect in the Pico remixes of the Pico songs doesn't pause when the song is paused (surely there's a better way to phrase this bug... but I can't think of one right now). This only happens in the Pico remixes - it doesn't happen in the regular/boyfriend song.

Steps to Reproduce

  1. Open the game
  2. Go into the freeplay menu
  3. Switch to Pico
  4. Play a Pico song
  5. Play the song as normal
  6. When a train passes, pause the game
  7. ?????
  8. Bug reproduced!
@Lasercar Lasercar added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Jan 27, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Jan 27, 2025

This bug has been a thing for as long as I can remember, but I don't think anyone's reported it yet.
Thanks for reporting!

@Hundrec Hundrec added status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage Awaiting review. labels Jan 27, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Jan 27, 2025

Here are some videos demonstrating this bug. Looks like the train sound doesn't pause any time the Philly erect stage is used.

Normal

normal.train.sound.mp4

Erect (bugged)

bugged.train.sound.mp4

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Jan 28, 2025

Seems like it's very easy to fix, these functions are in phillyTrain.hxc but not in phillyTrainErect.hxc

         public override function onPause(event:PauseScriptEvent) {
		super.onPause(event);

		// Temporarily stop ambiance.
		if (trainSound != null) trainSound.pause();
	}

	public override function onResume(event:ScriptEvent) {
		super.onResume(event);

		// Temporarily stop ambiance.
		if (trainSound != null) trainSound.resume();
	}

@Hundrec Hundrec added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels Jan 28, 2025
@Lasercar
Copy link
Contributor Author

Just wanted to add to this issue that the same thing happens with the lightning strikes in the new difficulty and pico versions of the two Skid and Pump songs.

@Hundrec
Copy link
Collaborator

Hundrec commented Jan 28, 2025

Hm, sounds like something @NotHyper-474 could add to the PR

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Jan 28, 2025

I may have come up with a better solution that automatically pauses/resumes every sound instead of having to manually handle it through the stage script. When I have battle-tested it enough I might make a PR on this repo.

same thing happens with the lightning strikes

Now that I think about it you might be talking about the lightning itself and not the sound, althought it happens with the sound as well, perhaps a bit out of scope for that PR.

@Lasercar
Copy link
Contributor Author

I was talking about both?

@NotHyper-474
Copy link
Contributor

Anyway, I think I found a way to fix both, although I'm not sure if it's safe since it requires pausing every currently active tween, whereas the original code only pauses some of them.

At the moment it doesn't seem to break anything, but just in case I'll still make the PR only pause sounds.

2025-01-28.16-04-32.mp4

@JackXson-Real
Copy link

They also need to fix the issue where the train sound occasionally doesn’t play on the normal stage.

@Lasercar
Copy link
Contributor Author

Lasercar commented Jan 29, 2025

Same thing also happens in Mommy Mearest songs with the car - except that the car sprite in the normal versions of the song actually pauses, though the sound doesn't, but then disappears once the sound effect finishes playing while the game's paused.

@Hundrec Hundrec added status: duplicate Issue or PR is redundant to another. and removed type: minor bug Involves a minor bug or issue. status: pending pull request Dependent on a pull request that is currently awaiting review. labels Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

This issue is a duplicate. Please direct all discussion to the original issue.

@Hundrec Hundrec closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate Issue or PR is redundant to another.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants