From 9e4b22553b7a120bd989fcd1851d243b590ba5cc Mon Sep 17 00:00:00 2001 From: Bogdan Mart Date: Sun, 16 Apr 2023 23:02:11 +0300 Subject: [PATCH 1/3] Replaced std::find_if to std::any_of in few places (#68) It looks like this would make code more readable: don't need to use iterators in if few lines below, and variable names `has**` now reflect variable content more. Co-authored-by: Bogdan Mart --- src/main.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index d7599a56..971079bc 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -234,24 +234,24 @@ namespace // We want a device that supports the ray tracing extension. const auto extensions = Vulkan::GetEnumerateVector(device, static_cast(nullptr), vkEnumerateDeviceExtensionProperties); - const auto hasRayTracing = std::find_if(extensions.begin(), extensions.end(), [](const VkExtensionProperties& extension) + const auto hasRayTracing = std::any_of(extensions.begin(), extensions.end(), [](const VkExtensionProperties& extension) { return strcmp(extension.extensionName, VK_KHR_RAY_TRACING_PIPELINE_EXTENSION_NAME) == 0; }); - if (hasRayTracing == extensions.end()) + if (!hasRayTracing) { return false; } // We want a device with a graphics queue. const auto queueFamilies = Vulkan::GetEnumerateVector(device, vkGetPhysicalDeviceQueueFamilyProperties); - const auto hasGraphicsQueue = std::find_if(queueFamilies.begin(), queueFamilies.end(), [](const VkQueueFamilyProperties& queueFamily) + const auto hasGraphicsQueue = std::any_of(queueFamilies.begin(), queueFamilies.end(), [](const VkQueueFamilyProperties& queueFamily) { return queueFamily.queueCount > 0 && queueFamily.queueFlags & VK_QUEUE_GRAPHICS_BIT; }); - return hasGraphicsQueue != queueFamilies.end(); + return hasGraphicsQueue; }); if (result == physicalDevices.end()) From 04309354ff73275bb4e075c7866d7d753489c1b8 Mon Sep 17 00:00:00 2001 From: Onuralp Sezer Date: Sun, 23 Apr 2023 21:21:49 +0300 Subject: [PATCH 2/3] docs: fedora installation method added (#70) Signed-off-by: Onuralp SEZER --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index e1bcdb12..0d9f9bc3 100644 --- a/README.md +++ b/README.md @@ -66,6 +66,14 @@ sudo apt-get install curl unzip tar libxi-dev libxinerama-dev libxcursor-dev xor ./build_linux.sh ``` +Fedora Installation + +``` +sudo dnf install libXinerama-devel libXcursor-devel libX11-devel libXrandr-devel mesa-libGLU-devel pkgconfig ninja-build cmake gcc gcc-c++ vulkan-validation-layers-devel vulkan-headers vulkan-tools vulkan-loader-devel vulkan-loader glslang glslc +./vcpkg_linux.sh +./build_linux.sh +``` + ## Random Thoughts - I suspect the RTX 2000 series RT cores to implement ray-AABB collision detection using reduced float precision. Early in the development, when trying to get the sphere procedural rendering to work, reporting an intersection every time the `rint` shader is invoked allowed to visualise the AABB of each procedural instance. The rendering of the bounding volume had many artifacts around the boxes edges, typical of reduced precision. From 531685923084b6e2a7fb6c651dc70f2919dc6afc Mon Sep 17 00:00:00 2001 From: Onuralp Sezer Date: Sun, 23 Apr 2023 21:38:37 +0300 Subject: [PATCH 3/3] vcpkg version updated to 2023.04.15 (#71) Signed-off-by: Onuralp SEZER --- vcpkg_linux.sh | 2 +- vcpkg_windows.bat | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vcpkg_linux.sh b/vcpkg_linux.sh index 9028ce33..2966de59 100755 --- a/vcpkg_linux.sh +++ b/vcpkg_linux.sh @@ -5,7 +5,7 @@ mkdir -p build cd build git clone https://github.com/Microsoft/vcpkg.git vcpkg.linux cd vcpkg.linux -git checkout 2023.02.24 +git checkout 2023.04.15 ./bootstrap-vcpkg.sh ./vcpkg install \ diff --git a/vcpkg_windows.bat b/vcpkg_windows.bat index ed8de6d1..fce80418 100644 --- a/vcpkg_windows.bat +++ b/vcpkg_windows.bat @@ -2,7 +2,7 @@ mkdir build cd build || goto :error git clone https://github.com/Microsoft/vcpkg.git vcpkg.windows || goto :error cd vcpkg.windows || goto :error -git checkout 2023.02.24 || goto :error +git checkout 2023.04.15 || goto :error call bootstrap-vcpkg.bat || goto :error vcpkg.exe install ^