Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

X-RateLimit-Reset #332

Open
Nosferican opened this issue Oct 18, 2019 · 3 comments
Open

X-RateLimit-Reset #332

Nosferican opened this issue Oct 18, 2019 · 3 comments

Comments

@Nosferican
Copy link

Is your feature request related to a problem? Please describe.
The API offers X-RATE-Limit and X-RATE-Remaining, but no X-Rate-resetAt.

Describe the solution you'd like
The headers should include a X-Rate-ResetAt.

Describe alternatives you've considered
The value could be a unix timestamp or a zoned date time.

Additional context
X-Rate-resetAt is very valuable in case someone is reaching the limit, but it also fully specifies the rate limit per period. Currently, the information on the rate limit is 1,000 / unknown time period.

@froi
Copy link
Contributor

froi commented Oct 18, 2019

Hey peeps! Long time no see code.gov.

@Nosferican I think that's not a Code.gov thing. The rate limit is handled by https://api.data.gov/ as well as the api key. The response headers are added by them.

At least it was like that when I was around 😄

@Nosferican
Copy link
Author

Thanks for the information. I found NREL/api-umbrella#377 (created on 2017-07-30) which had that request. On this end, maybe we should document that it uses the api.data.gov and a link to their docs.

@ioggstream
Copy link

FYI there's an ongoing work for standardizing ratelimit headers under HTTP, that is supported by various implementors and governments. See:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants