Improve shell escaping and handling #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where we call shell scripts with arguments that may not have been properly escaped if the argument contained spaces or other special characters. So, for example, if you set your data directory to a path with spaces, these commands could fail.
This fixes it by shifting our blocking shell calls to use lua-shell-games, which is a library I extracted to better handle escaping and the various oddities around calling shell commands in different versions of Lua. That separate library has much better test coverage for shell-specific things and testing across different Lua versions.
This also fixes the issue for our non-blocking shell calls (still made via lua-resty-shell) by using the same quoting utility functions from lua-shell-games.