Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CovModel.opt_arg should be sorted #103

Closed
MuellerSeb opened this issue Sep 20, 2020 · 0 comments · Fixed by #108
Closed

CovModel.opt_arg should be sorted #103

MuellerSeb opened this issue Sep 20, 2020 · 0 comments · Fixed by #108
Assignees
@MuellerSeb
Labels
bug Something isn't working enhancement New feature or request
Milestone
1.3

Comments

@MuellerSeb
Copy link
Member

MuellerSeb commented Sep 20, 2020 •
edited
Loading

GSTools/gstools/covmodel/base.py

Line 166 in 67a228d

self._opt_arg = list(opt_arg.keys())

In order to have a unique representation for an argument list, the optional arguments CovModel.opt_arg should be sorted by name.
This should be done in CovModel.__init__ at the shown line of code.
@MuellerSeb MuellerSeb added bug Something isn't working enhancement New feature or request labels Sep 20, 2020
@MuellerSeb MuellerSeb added this to the 1.3 milestone Sep 20, 2020
@MuellerSeb MuellerSeb self-assigned this Sep 20, 2020
@MuellerSeb MuellerSeb changed the title CovModel.opt_arg should be sorted CovModel.opt_arg should be sorted Sep 20, 2020
@MuellerSeb MuellerSeb mentioned this issue Nov 10, 2020
Merged
@MuellerSeb MuellerSeb linked a pull request Nov 10, 2020 that will close this issue
CovModel: sort opt_arg #108
Merged
@MuellerSeb MuellerSeb mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuellerSeb MuellerSeb

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

CovModel: sort opt_arg GeoStat-Framework/GSTools
1 participant
@MuellerSeb