Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] vario_estimate: prevent altering the input field #180

Merged
merged 1 commit into from
Jun 9, 2021
Merged

[fix] vario_estimate: prevent altering the input field #180

merged 1 commit into from
Jun 9, 2021

Conversation

MuellerSeb
Copy link
Member

closes: #179

@MuellerSeb MuellerSeb added the bug Something isn't working label Jun 9, 2021
@MuellerSeb MuellerSeb added this to the 1.3.2 milestone Jun 9, 2021
@MuellerSeb MuellerSeb requested a review from LSchueler June 9, 2021 11:03
@MuellerSeb MuellerSeb self-assigned this Jun 9, 2021
LSchueler
LSchueler reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Maybe we should systematically add some unit tests to check for such things, but I guess that is not the scope of this PR.

@MuellerSeb MuellerSeb merged commit e89bf1b into develop Jun 9, 2021
@MuellerSeb MuellerSeb deleted the vario_est_field_fix branch June 9, 2021 11:34
@MuellerSeb MuellerSeb mentioned this pull request Jul 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler approved these changes

Assignees

@MuellerSeb MuellerSeb

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

BUG: vario_estimate alters field
2 participants
@MuellerSeb @LSchueler