New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cython routines to have same signatures as rust implementations #216

Closed

MuellerSeb opened this issue Nov 2, 2021 · 1 comment

Assignees

Labels

organization Performance Refactoring

Milestone

Member

MuellerSeb commented Nov 2, 2021

In order to have drop-in replacements for the Cython routines we need to refactor the existing cython routines:

variogram
- remove dim argument from directional, unstructured
  https://github.com/GeoStat-Framework/GSTools-Core/blob/afe9ec1134d19fc9bde8ae8466132433315718a0/src/variogram.rs#L240
  https://github.com/GeoStat-Framework/GSTools-Core/blob/afe9ec1134d19fc9bde8ae8466132433315718a0/src/variogram.rs#L357

The text was updated successfully, but these errors were encountered:

MuellerSeb added Refactoring organization Performance labels

MuellerSeb added this to the 1.3.4 milestone

MuellerSeb self-assigned this

MuellerSeb mentioned this issue

Add optional dependency GSTools-Core #215

Merged

Member

LSchueler commented Nov 11, 2021

Closed with PR #215

LSchueler closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment