Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are Travis/Appveyor always uploading wheels? #62

Closed
banesullivan opened this issue Jan 12, 2020 · 3 comments
Closed

Why are Travis/Appveyor always uploading wheels? #62

banesullivan opened this issue Jan 12, 2020 · 3 comments
Assignees
Labels
CI/CD wontfix This will not be worked on

Comments

@banesullivan
Copy link
Collaborator

The Travis and Appveyor scripts upload a built wheel on every build...

GSTools/.travis.yml

Lines 123 to 127 in 5326163

after_success:
# pypi upload ("test" allways and "official" on TAG)
- python -m pip install twine
- python -m twine upload --verbose --skip-existing --repository-url https://test.pypi.org/legacy/ wheelhouse/*.whl
- python -m twine upload --verbose --skip-existing --repository-url https://test.pypi.org/legacy/ dist/*.tar.gz

- python -m twine upload --skip-existing --repository-url https://test.pypi.org/legacy/ wheelhouse/*.whl

Why? This seems excessive and it will cause a failed build on PRs from any forks (see #57 and #59)

@MuellerSeb
Copy link
Member

You need to make the PRs in the develop branch, since the master branch only holds the latest release.

The .travis.yaml was updated in this branch:

if [[ $TRAVIS_PULL_REQUEST == 'false' ]]; then

So the exact thing you described was already solved. ;-)

@MuellerSeb MuellerSeb self-assigned this Jan 13, 2020
@MuellerSeb MuellerSeb added CI/CD wontfix This will not be worked on labels Jan 13, 2020
@LSchueler
Copy link
Member

I just clarified from which branch to fork in the CONTRIBUTING.MD

@MuellerSeb
Copy link
Member

@LSchueler : thx! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants