Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krige unification #97

Merged
merged 17 commits into from
Jul 17, 2020
Merged

Krige unification #97

merged 17 commits into from
Jul 17, 2020

Conversation

MuellerSeb
Copy link
Member

Closes #79
Fixes #89

Here comes the great unification of our krige submodule:

  • Swiss Army Knife for kriging: The Krige class now provides everything in one place
  • "Kriging the mean" is now possible with the switch only_mean in the call routine
  • Simple/Ordinary/Universal/ExtDrift/Detrended are only shortcuts to Krige with limited input parameter list
  • We now use the covariance function to build up the kriging matrix
  • An unbiased switch was added to enable simple kriging (where the unbiased condition is not given)
  • An exact switch was added to allow smother results, if a nugget is present in the model
  • An cond_err parameter was added, where measurement error variances can be given for each conditional point
  • pseudo-inverse matrix is now used to solve the kriging system (can be disabled by the new switch pseudo_inv), this is equal to solving the system with least-squares and prevents numerical errors
  • New examples added
  • New tests added

PS: I needed to create a new PR, since there were some commits in the branch, that weren't recognized by the last PR.

@MuellerSeb MuellerSeb added enhancement New feature or request Refactoring Code-Refactoring needed here Performance Performance related stuff. labels Jul 15, 2020
@MuellerSeb MuellerSeb added this to the 1.3 milestone Jul 15, 2020
@MuellerSeb MuellerSeb requested a review from LSchueler July 15, 2020 16:19
@MuellerSeb MuellerSeb self-assigned this Jul 15, 2020
@MuellerSeb
Copy link
Member Author

I still need to update the call signatures of the different kriging methods to include the pseudo_inv_type.

@MuellerSeb MuellerSeb changed the base branch from master to develop July 16, 2020 10:24
@MuellerSeb
Copy link
Member Author

I still need to update the call signatures of the different kriging methods to include the pseudo_inv_type.

Done. @LSchueler you can start your review ;-)

Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I already said in PR #95, great work!

Just a typo hint and a suggestion to think about. Functions are first class objects in Python, hurray!!

examples/05_kriging/01_ordinary_kriging.py Show resolved Hide resolved
examples/05_kriging/09_pseudo_inverse.py Outdated Show resolved Hide resolved
gstools/krige/base.py Show resolved Hide resolved
@LSchueler LSchueler merged commit 684e28a into develop Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Performance Performance related stuff. Refactoring Code-Refactoring needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Kriging values Proposal: unify kriging routines
2 participants