Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator: add abstract __init__ #259

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Generator: add abstract __init__ #259

merged 1 commit into from
Aug 16, 2022

Conversation

MuellerSeb
Copy link
Member

The abstract __init__ was missing in the abstract generator base class.

@MuellerSeb MuellerSeb added the enhancement New feature or request label Aug 16, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone Aug 16, 2022
@MuellerSeb MuellerSeb self-assigned this Aug 16, 2022
@MuellerSeb
Copy link
Member Author

Needed to ignore W0231 in pylint (super-init-not-called), since abstract __init__ routines will only be excluded from that rule with the next pylint release (2.15).

See: pylint-dev/pylint#3975

@MuellerSeb MuellerSeb merged commit 58cc52b into main Aug 16, 2022
@MuellerSeb MuellerSeb deleted the custom-generators branch August 16, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MuellerSeb MuellerSeb

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
1 participant
@MuellerSeb