Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different distances apart from the euclidean #120

Closed
gsantam opened this issue Jan 25, 2019 · 3 comments
Closed

Different distances apart from the euclidean #120

gsantam opened this issue Jan 25, 2019 · 3 comments

Comments

@gsantam
Copy link

gsantam commented Jan 25, 2019

Hi,

have you considered adding other distances apart from the euclidean, or letting the user customize their own distance? If you are interested in this feature I could start working on it.

@rth
Copy link
Contributor

rth commented Feb 5, 2019

Currently, we also support great-circle distance.

I think other distance metrics could be interesting but some code re-factoring (#56 and #31) might be beneficial before doing that. Currently, as we saw with the great-circle distance adding a new distance requires repetitive changes all through the code base (also related to #121), and it would be preferable if that could be avoided as much as possile.

You are very welcome to contribute in general though.

@MuellerSeb
Copy link
Member

One thing to have in mind: As with the great-circle distance, the meaning of anisotropy depends on your metric. When handling #133 with an isotropic n-dimensional kriging, the distance calculation could be just a plugin.

Since scipys cdist is used to calculate pairwise distances, we could simply provide all their metrics by passing through the metric keyword.

@MuellerSeb
Copy link
Member

We will discuss this here: #143. Closing for now. Feel free to Re-open or (better) discuss in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants