Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and modernize file handling in Harvest module #4368

Open
dafeder opened this issue Dec 20, 2024 · 0 comments
Open

Improve and modernize file handling in Harvest module #4368

dafeder opened this issue Dec 20, 2024 · 0 comments

Comments

@dafeder
Copy link
Member

dafeder commented Dec 20, 2024

Following up on #4276, we should try to eliminate the Drupal\common\Util\DrupalFiles class, since it's only used in Drupal\harvest\Transform\ResourceImporter and ResourceLocalizer service, uses soon-deprecated system_retrieve_file and does not handle file wrappers correctly.

If it's going to be too hard to remove DrupalFiles:

  • Refactor DrupalFiles to play nice with vfsStream and also to not use system_retrieve_file().
  • Turn Drupal\Tests\harvest\Functional\Transform\ResourceImporterTest into a kernel test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant