feat(components): Add testID to Divider and dynamically reference size and direction props #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published Pre-release for cb11119 with versions: To install the new version(s) for Web run: |
taylorvnoj
commented
Nov 22, 2024
| @@ -3,7 +3,7 @@ | |||
| exports[`Divider should render 1`] = ` | |||
| <div> | |||
| <div | |||
| class="divider horizontal" | |||
| class="divider base horizontal" | |||
There was a problem hiding this comment.
The word "base" was added to the snapshot test because the css was refactored to include a base size (and base is default)
Aiden-Brine
reviewed
Nov 25, 2024
Aiden-Brine
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Updating
Dividerin@jobber/componentsas part of our continued effort to increase prop consistency between equivalent web and mobile components.Now
Dividerprops are exactly the same in mobile and web versionsChanges
Added
A new
testIDprop exists on thediv. A test for that prop was also added inDivider.test.tsxChanged
In following a similar pattern to other components in Atlantis, I decided to dynamically reference the size and direction props to ensure the component is tightly coupled to the available size/direction options. This means a few new files were created -
DividerSizes.module.cssandDividerDirections.module.css. This also DRYs up a bit of the logic inDivider.tsxTesting
Testing the pre-release in product is linked below.
UI/UX wise, everything remains the same as it was before. You can now add a
testID.In Atlantis we use Github's built in pull request reviews.