Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle notifier errors; explicit failure for webhook notifiers #23

Open
4 tasks
gg-mmill opened this issue Sep 8, 2022 · 0 comments
Open
4 tasks

Handle notifier errors; explicit failure for webhook notifiers #23

gg-mmill opened this issue Sep 8, 2022 · 0 comments

Comments

@gg-mmill
Copy link
Contributor

gg-mmill commented Sep 8, 2022

Context

Right now, if one notifier raises, the program will stop (i.e. further notifiers will not be triggered).
Also webhook notifiers fail silently

DoD

  • if one notifier fails:
    • handle and log the exception/error
    • return non-null error code at the end of the program (so that when looking at cloudwatch monitoring, we can see there are issues)
  • Raise when webhook notifier did not perform a successful call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant